Shoes should be smooth-soled to enable you to spin easily, leather soles are best for this but synthetic soles are ok as long as they don't have too much grip. Ordinary training-shoes are not good for salsa because the grip of the soles can put a lot of strain on your knees as you try to spin.
